Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-893

Synchronize calls in SentryClient and create sentry client once per request in SimpleDBProvider

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.0
    • 1.7.0
    • None
    • None

    Description

      We periodically see "out of sequence response" error from thrift layer as thrift itself is not thread safe and lets mutliple clients read each other's sockets. See http://mail-archives.apache.org/mod_mbox/thrift-user/201208.mbox/%3CA0F963DCF29346458CDF2969683DF6CC70F90B3A@SC-MBX01-2.TheFacebook.com%3E

      Caused by: sentry.org.apache.thrift.TApplicationException: list_sentry_privileges_for_provider failed: out of sequence response at sentry.org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:76)

      Would be best to synchronize the calls on client side to avoid this situation. We might follow up to allow locking just the transport.

      Attachments

        1. SENTRY-893.1.patch
          22 kB
          Sravya Tirukkovalur
        2. SENTRY-893.2.patch
          25 kB
          Sravya Tirukkovalur
        3. SENTRY-893.3.patch
          25 kB
          Sravya Tirukkovalur
        4. SENTRY-893.patch
          17 kB
          Sravya Tirukkovalur

        Issue Links

          Activity

            People

              sravya Sravya Tirukkovalur
              sravya Sravya Tirukkovalur
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: