Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-2403

Incorrect naming in RollingFileWithoutDeleteAppender

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.6.0
    • 2.2.0
    • None

    Description

      RollingFileWithoutDeleteAppender names the log files incorrectly. The current timestamp is appended to the end of the current log file when rollOver() is called and the previous timestamp is not removed.

      The following files are generated:

      auditLog.log.1536920157248
      auditLog.log.1536920157248.1536920157256
      auditLog.log.1536920157248.1536920157256.1536920157265
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268.1536920157270
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268.1536920157270.1536920157272
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268.1536920157270.1536920157272.1536920157274
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268.1536920157270.1536920157272.1536920157274.1536920157276
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268.1536920157270.1536920157272.1536920157274.1536920157276.1536920157278
      auditLog.log.1536920157248.1536920157256.1536920157265.1536920157268.1536920157270.1536920157272.1536920157274.1536920157276.1536920157278.1536920157279
      

      This can cause problem on certain filesystems (e.g. ext4) when the filename reaches 255 characters.

      Attachments

        1. SENTRY-2403.001.patch
          5 kB
          Peter Somogyi
        2. SENTRY-2403.002.patch
          5 kB
          Peter Somogyi

        Issue Links

          Activity

            psomogyi Peter Somogyi added a comment -

            Could someone assign me to this issue? I don't have an option for this.

            psomogyi Peter Somogyi added a comment - Could someone assign me to this issue? I don't have an option for this.
            psomogyi Peter Somogyi added a comment -

            I used an incorrect patch format in version 1. Uploaded a correct one using git diff > SENTRY-2403.001.patch.

            psomogyi Peter Somogyi added a comment - I used an incorrect patch format in version 1. Uploaded a correct one using git diff >  SENTRY-2403 .001.patch.
            spena Sergio Peña added a comment -

            psomogyi Can you submit your patch to review board and add a link in this jira?

            spena Sergio Peña added a comment - psomogyi Can you submit your patch to review board and add a link in this jira?
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12939709/SENTRY-2403.001.patch against master.

            Overall: +1 all checks pass

            SUCCESS: all tests passed

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4119/console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12939709/SENTRY-2403.001.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4119/console This message is automatically generated.
            hadoopqa Hadoop QA added a comment -

            Here are the results of testing the latest attachment
            https://issues.apache.org/jira/secure/attachment/12939716/SENTRY-2403.002.patch against master.

            Overall: +1 all checks pass

            SUCCESS: all tests passed

            Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4120/console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12939716/SENTRY-2403.002.patch against master. Overall: +1 all checks pass SUCCESS: all tests passed Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/4120/console This message is automatically generated.
            psomogyi Peter Somogyi added a comment -

            Thanks spena for the review!

            psomogyi Peter Somogyi added a comment - Thanks spena for the review!

            People

              psomogyi Peter Somogyi
              psomogyi Peter Somogyi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: