[SENTRY-2066] DB name is not set for AlterTable

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Sentry
• Labels: 2.0
• Assignee: Na Li
• Reporter: Na Li
• Created: 21/Nov/17 02:58
• Updated: 22/May/18 16:23
• Resolved: 22/Nov/17 00:37

Description

SENTRY-1087 introduced a regression: the database name is not set in alter table column command.

SENTRY-1087 added a new case below, and it causes the currDB not set because its children are "TOK_TABNAME" and "TOK_ALTERTABLE_RENAMECOL" NONE IS "TOK_ALTERTABLE_SERIALIZER"

case HiveParser.TOK_ALTERTABLE:
      
              for (Node childNode : ast.getChildren()) {
                ASTNode childASTNode = (ASTNode) childNode;
                if ("TOK_ALTERTABLE_SERIALIZER".equals(childASTNode.getText())) {
                  ASTNode serdeNode = (ASTNode) childASTNode.getChild(0);
                  String serdeClassName = BaseSemanticAnalyzer.unescapeSQLString(serdeNode.getText());
                  setSerdeURI(serdeClassName);
                  currDB = getCanonicalDb();
                }
              }
              break;

Issue Links

• relates to: SENTRY-1209 Sentry does not block Hive's cross-schema table renames
• links to: Review Link for this case