Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1744

Simplify creation of DelegateSentryStore

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.8.0, 2.0.0
    • 1.8.0, 2.0.0
    • Sentry
    • None

    Description

      It looks like we have a very "generic" code in SentryGenericPolicyProcessor that creates DelegateSentryStore based on the class name which may be changed in configuration. This is very cute, but sounds quite complicated to me. I don't know the history here, but I would suggest removing this and just creating DelegateSentryStore directly.

      Attachments

        1. SENTRY-1744.001.patch
          10 kB
          Alex Kolbasov

        Issue Links

          is related to

          Sub-task - The sub-task of the issue SENTRY-404 Extending Sentry thrift interface and adding a processor for generic authorization model

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Code Review

          Activity

            People

              akolb Alex Kolbasov
              akolb Alex Kolbasov
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: