[SENTRY-1664] HMSPaths compares strings using ==

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 1.8.0
• Component/s: Sentry
• Labels: bite-sized newbie
• Assignee: Krishna Kalyan
• Reporter: Alex Kolbasov
• Created: 15/Mar/17 06:34
• Updated: 10/Jul/17 15:51
• Resolved: 10/Jul/17 15:29

Description

HMSPaths contains the following code:

  void renameAuthzObject(String oldName, List<List<String>> oldPathElems,
      String newName, List<List<String>> newPathElems) {

    if ( oldPathElems == null || oldPathElems.size() == 0 || newPathElems == null || newPathElems.size() == 0
            || newName == null || oldName == null || oldName == newName) {
      return;
    }

Note that it used oldName == newName comparison which isn't correct - it should use equals(). Also, instead of using size() it should use isEmpty()

Issue Links

• is part of: SENTRY-1644 Partition ACLs disappear after renaming Hive table with partitions