Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1625

PrivilegeOperatePersistence can use QueryParamBuilder

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.8.0, 2.0.0
    • 1.8.0, 2.0.0
    • Sentry
    • None

    Description

      PrivilegeOperatePersistence has a few places where it builds queries using StringBuilder. It can benefit from the new QueryParamBuilder introduced in SentryStore.

      So I moved QueryParamBuilder to a separate class, moved a few methods from MSentryGMPrivilege to PrivilegeOperatePersistence (they were only used there) and converted all string-based query builders to QueryParamBuilder.

      Attachments

        1. SENTRY-1625.001.patch
          54 kB
          Alex Kolbasov
        2. SENTRY-1625.001-sentry-ha-redesign.patch
          58 kB
          Alex Kolbasov

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-1476 SentryStore is subject to JDQL injection

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-1609 DelegateSentryStore is subject to JDQL injection

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Code Review

          Activity

            People

              akolb Alex Kolbasov
              akolb Alex Kolbasov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: