Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1515

Cleanup exception handling in SentryStore

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 1.8.0, 2.0.0
    • Sentry
    • None

    Description

      The changes to SENTRY-1422 and SENTRY-1512 changed the semantics of several API calls:

      • hasAnyServerPrivileges
      • getMSentryPrivileges
      • getMSentryPrivilegesByAuth
      • getRoleNamesForGroups
      • retrieveFullPrivilegeImage
      • retrieveFullRoleImage
      • retrieveFullPathsImage
      • getAllRoleNames

      Previously they were not marked as throwing Exception, but they still could do it. With the change they now ignore exceptions and just log them which may not be the right thing to do.

      Instead they should be marked as throwing exceptions which has consequence for broader APIs which should be marked as well.

      Attachments

        1. SENTRY-1515.001.patch
          42 kB
          Alex Kolbasov

        Issue Links

          relates to

          Sub-task - The sub-task of the issue SENTRY-1422 JDO deadlocks while processing grant while a background thread processes Notificationlogs

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SENTRY-1512 Refactor the database transaction management

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Code Review

          Activity

            People

              akolb Alex Kolbasov
              akolb Alex Kolbasov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: