[SENTRY-1270] Improve error handling - Database with malformed URI causes NPE in HMS plugin during DDL

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0, 2.0.0
• Assignee: Sravya Tirukkovalur
• Reporter: Lenni Kuff
• Created: 18/May/16 05:13
• Updated: 24/Jul/17 15:36
• Resolved: 27/Oct/16 20:26

Description

Exception:

Caused by: java.lang.NullPointerException
        at org.apache.sentry.hdfs.MetastorePlugin.applyLocal(MetastorePlugin.java:336)
        at org.apache.sentry.hdfs.MetastorePlugin.processUpdate(MetastorePlugin.java:364)
        at org.apache.sentry.hdfs.MetastorePlugin.notifySentryAndApplyLocal(MetastorePlugin.java:341)
        at org.apache.sentry.hdfs.MetastorePlugin.renameAuthzObject(MetastorePlugin.java:292)
        at org.apache.sentry.binding.metastore.SentryMetastorePostEventListener.renameSentryTablePrivilege(SentryMetastorePostEventListener.java:336)
        at org.apache.sentry.binding.metastore.SentryMetastorePostEventListener.onAlterTable(SentryMetastorePostEventListener.java:194)
        at org.apache.hadoop.hive.metastore.HiveMetaStore$HMSHandler.alter_table_core(HiveMetaStore.java:3439)
        ... 21 more

When looking in the HMS database we found:

SELECT "NAME", "DB_LOCATION_URI" FROM "DBS" WHERE NOT "DB_LOCATION_URI" LIKE 'hdfs://%/%';
NAME | DB_LOCATION_URI 
-----------+--------------------
db_name | hdfs://nameservice1
(1 row)

Fixed by manually updating the HMS DB:

UPDATE DBS
SET DB_LOCATION_URI='hdfs://nameservice1/user/hive/warehouse/db_name.db'
WHERE DB_ID=12345;

We should handle this more gracefully in Sentry.

Issue Links

• relates to: SENTRY-1295 Investigate malformed paths in HMS db
• relates to: SENTRY-1508 MetastorePlugin.java does not handle properly initialization failure