[RANGER-4769] Admin audit generation: avoid code duplication by moving the implementation to base classes

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: Ranger
• Assignee: Madhan Neethiraj
• Reporter: Madhan Neethiraj
• Created: 05/Apr/24 22:36
• Updated: 31/May/24 13:24
• Resolved: 22/May/24 07:53

Description

When an object (like policy, security-zone, role) is updated, admin audit logs are generated with the details of the updated attributes. The logic to compute updated attributes is implemented in 13 classes, as listed below:

1. RangerPolicyService.getTransactionLog()
2. RangerRoleService.getTransactionLog()
3. RangerSecurityZoneServiceService.getTransactionLog()
4. RangerServiceService.getTransactionLog()
5. RangerGdsBaseModelService.createTransactionLog()
6. XAssetService.getTransactionLog()
7. XAuditMapService.getTransactionLog()
8. XGroupService.getTransactionLog()
9. XGroupUserService.getTransactionLog()
10. XPermMapService.getTransactionLog()
11. XPortalUserService.getTransactionLog()
12. XResourceService.getTransactionLog()
13. XUserService.getTransactionLog()

To avoid unnecessary code duplication, consider moving implementations in above classes to their base class - like RangerBaseModelService and AbstractBaseResourceService.

Issue Links

• causes: RANGER-4804 Encountering a '404 Not Found' page when assigning two or more groups to a user during editing