Details
Description
query results is incorrect when pk involved using '=' .
for example,
crate a table use sql:
create table bugTable(ID varchar primary key,company varchar);
upsert values use sql:
upsert into bugTable values('i1','c1');
upsert into bugTable values('i2','c2');
upsert into bugTable values('i3','c3');
the table is now like below,
----------------------+
ID | COMPANY |
----------------------+
i1 | c1 |
i2 | c2 |
i3 | c3 |
----------------------+
then use sql to query result from bugTable,
select * from bugTable where ID = 'i1' or (ID = 'i2' and company = 'c3');
the result expected:
----------------------+
ID | COMPANY |
----------------------+
i1 | c1 |
----------------------+
but, phoenix return the wrong result like below,
----------------------+
ID | COMPANY |
----------------------+
i1 | c1 |
i2 | c2 |
----------------------+
the condition company = 'c3' is not used at all !
and then you can find when sql query combine primary key '=' somthing with any condition,then the condition is not used at all either, it means when the sql like this,
select xxx from xxx where pk = 'xxx' or (pk = 'xx' and any other condition);
the any other condition does not used at all.
I test the sql below all versions in phoenix before(including) version 4.3.1 & 3.3.1, it turns out that all the version sql query result is wrong.
I read the source code, and thought maybe the problem because when compile the sql query, the pushKeyToExpression method lost the condition, and method evaluate in AndOrExpression is not work.