[PDFBOX-5594] Remove finalize from TrueTypeFont

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0 PDFBox
• Fix Version/s: 3.0.0 PDFBox
• Component/s: FontBox
• Assignee: Andreas Lehmkühler
• Reporter: Andreas Lehmkühler
• Created: 05/May/23 06:11
• Updated: 18/Aug/23 05:46
• Resolved: 05/May/23 06:15

Description

The usage of finalize is discouraged so that it is a good idea to remove it.

I've found a way to do so for org.apache.fontbox.ttf.TrueTypeFont.

All the data of a RandomAccessReadDataStream is copied to a final byte array. The additional RandomAccessReadBuffer isn't needed at all, so that it is save to do nothing when closing a RandomAccessReadDataStream. Now it is save to remove the finalize override from TrueTypeFont