[PDFBOX-4167] OutOfMemoryError on FlateFilter - Deflater.end() is missing

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.8, 2.0.9
• Fix Version/s: 2.0.10, 3.0.0 PDFBox
• Component/s: Writing
• Environment: Windows 7 x64, Java 8 SE
• Assignee: Tilman Hausherr
• Reporter: MINAKAMI Hiroki
• Created: 26/Mar/18 13:47
• Updated: 21/Jun/18 20:27
• Resolved: 27/Mar/18 16:14

Description

While creating some large PDF documents by PDFBox 2.0.8 and 2.0.9, I met an OutOfMemoryError on FlateFilter.encode().
While creating some small PDF documents, there are no problems.

I checked the source code of org.apache.pdfbox.filter.FlateFilter.java, and I found that calling of Deflater.end() method is missing.

When DeflaterOutputStream object is created by the 'new DeflaterOutputStream(encoded,deflater)' constructor method (i.e. 'custom deflater' is given),
DeflaterOutputStream.close() API does not call 'deflater.end()' method automatically.
Deflater.end() method may be called by the finalizer at GC, of cource, but the timing of GC is undecidable by user. So 'deflater.end()' method should be called explicitly. Otherwise it may cause an OutOfMemoryError.