[PARQUET-1683] Remove unnecessary string converting in readFooter method

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.11.0
• Fix Version/s: 1.11.0
• Component/s: parquet-mr
• Labels: pull-request-available
• Assignee: Xinli Shang
• Reporter: Xinli Shang
• Created: 21/Oct/19 16:47
• Updated: 24/Oct/19 12:27
• Resolved: 24/Oct/19 12:27

Description

The method (String filePath = file.toString()) is always called even filePath is not used(it is only used when an exception is thrown which is rare).  This kind of string conversion should be avoided when it is not used in terms of memory & CPU efficiency. 

 

https://github.com/apache/parquet-mr/pull/695

Issue Links

• links to: GitHub Pull Request #695