Getter/Setter type inconsistency in Entity IdClass

• Key: OPENJPA-257
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Jonathan Feinberg
• Component/s: jpa
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.0

Description

In this excerpt from ClassMetaData, we are seeking getter and setter in an identity class. We should be seeking getter and setter with type of Entity class's *key*, not type of Entity class per se. The getter code refers to "c", which was earlier set to the correct object id field type. But the setter-seeking code refers incorrectly to "fmds[i].getDeclaredType()". This is a show-stopper, as it makes OpenJPA manual section 3.2 un-implementable.

if (m == null || !m.getReturnType().isAssignableFrom(c))
                    throw new MetaDataException(_loc.get("invalid-id",
                        _type, fmds[i].getName()));
                m = Reflection.findSetter(oid, fmds[i].getName(),
                    fmds[i].getDeclaredType(), false);
                if (m == null || m.getReturnType() != void.class)
                    throw new MetaDataException(_loc.get("invalid-id",
                        _type, fmds[i].getName()));

Comments

[Jonathan Feinberg]

I can work around it by declaring both

void setFoo(String fooKey) { foo = fooKey; }

void setFoo(Foo foo) { foo = foo.getId() }

In the identity class, but this is cheesy.

[Pinaki Poddar]

Attached patch to find Application Identity class' setter method with correct parameter type.

[Michael Dick]

Looks like this has already been fixed, or at any rate Pinaki's change is already committed.