[OPENJPA-2463] Wrong logging level on message issued by the fix to OPENJPA-2233

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.1, 2.1.2, 2.2.2, 2.2.1.1
• Fix Version/s: 2.4.0
• Component/s: Enhance
• Labels: error-feedback
• Environment: OpenJPA as bundled on WebSphere 8.5.5
• Assignee: Richard G. Curtis
• Reporter: Rafael Teixeira
• Created: 04/Dec/13 15:53
• Updated: 21/Sep/16 14:38
• Resolved: 17/Dec/13 02:44

Description

Patch for issue OPENJPA-2233 introduced a message when a Embeddable entity defines an ID property, which the Enhancer can't properly add a helper method (getIDOwningClass).

— openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java (revision 1325823)
+++ openjpa-kernel/src/main/java/org/apache/openjpa/enhance/PCEnhancer.java (working copy)
@@ -1150,6 +1150,11 @@
if (_meta.hasAbstractPKField() == true)

{ addGetIDOwningClass(); }

+
+ if (_meta.isEmbeddedOnly()
+ && _meta.getIdentityType() == ClassMetaData.ID_APPLICATION)

{ + _log.error(_loc.get("ID-field-in-embeddable-unsupported", _meta.toString())); + }

addNewObjectIdInstanceMethod(true);
addNewObjectIdInstanceMethod(false);

The problem is that this message is also emitted when inheriting from a MappedSuperClass, containing an Id field/property, which is a very common pattern.

As the persistence engine of OpenJPA works perfectly with such a class hierarchy (and even the Enhancer with the complement of that patch just skips adding a call to the non-added helper method), it is pointless to alarm operations personnel with a message labeled and tagged as an error.

Therefore I suggest to log it as a warning, also editing the corresponding message text to better indicate that the Enhancer will simply not add/call the helper method, skipping a potential optimization.

Issue Links

• is related to: OPENJPA-2233 Failed to invoke pcGetIDOwningClass method on embeddable entity with ID annotation
• relates to: OPENJPA-2478 Erroneous message from the enhancer when a Mapped Superclass contains an @Id.