[NUTCH-2253] ProtocolFactory still not thread-safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.10, 1.11
• Fix Version/s: 1.16
• Component/s: fetcher
• Assignee: Unassigned
• Reporter: Leon Misakyan
• Created: 20/Apr/16 15:54
• Updated: 28/Jan/21 13:56
• Resolved: 22/Nov/19 15:12

Description

Hi, as I can see in 1.11 release, ProtocolFactory class still has an issue in getProtocol method. This is because every fetcher thread has its own ProtocolFactory instance (this.protocolFactory = new ProtocolFactory(conf); in FetcherThread constructor.)
So have this method synchronized is useless, because each thread has its own monitor.
In our project we have issue of having multiple Protocol instances.
Issue can be fixed if getProtocol method will use shared conf instance as lock object or by having one ProtocolFactory for all fetcher threads.

Issue Links

• is duplicated by: NUTCH-2625 ProtocolFactory.getProtocol(url) may create multiple plugin instances