Trivial Description
The JavaDoc comment for FtpClient.setControlKeepAliveReplyTimeout(Duration) is technically incorrect:
/**
* Sets how long to wait for control keep-alive message replies.
*
* @param timeout number of milliseconds to wait (defaults to 1000)
* @since 3.0
* @see #setControlKeepAliveTimeout(Duration)
*/
public void setControlKeepAliveReplyTimeout(final Duration timeout) {
controlKeepAliveReplyTimeout = DurationUtils.zeroIfNull(timeout);
}
The timeout is no longer "number of milliseconds" because it's a Duration and so has the unit embedded within. The JavaDoc also doesn't document the behavior when null is given.
Perhaps this something like
@param timeout amount of time to wait. This defaults to 1000 milliseconds if not explicitly set. A value of {@code null} disables the timeout.
I'm sure you can do better than I can.