Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-4648

PushContextImpl - different behaviour when socket is not connected

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0.1, 4.0.2, 4.1.0-RC1, 5.0.0
    • 4.0.2, 4.1.0-RC1, 5.0.0
    • General
    • None

    Description

      Hi,

      when sending a message via PushContextImpl, the behaviour differs when using methods with or without user specification.

      A new FacesException is thrown when the send() method is used without a user specification and without an open channel:

      throw new FacesException("CDI bean not found for push message");

      When using send() with a user specified, an empty HashMap is returned.
       
      I think the behavior should be the same - either Exception (not recommended) or an empty result.
       
      What do you think about this? I am able to prepare a PR (for whatever version you need), but let me know what result you chose.
       
      Br
      Milan
       

      Attachments

        Activity

          People

            Unassigned Unassigned
            milansi Milan Siebenbürger
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: