Uploaded image for project: 'MyFaces Core'
  1. MyFaces Core
  2. MYFACES-363 h:graphicImage provides several illegal attributes
  3. MYFACES-439

HtmlSwapImageTag should extend org.apache.myfaces.taglib.html.ext.HtmlGraphicImageTag

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 1.1.0
    • 1.1.0
    • General
    • None
    • Weblogic 8.1 SP3

    Description

      Moving the non-JSF specified HTML 4.0 <img> attributes out of HtmlGraphicImageTagBase and into the extension HtmlGraphicImageTag (as was appropriate) caused MyFaces to break on Weblogic 8.1 because Weblogic validates the .tld and checks that there are appropriate setters in the *Tag class for each specified <attribute>. Since HtmlSwapImageTag was extending HtmlGraphicImageTagBase, it no longer has the appropriate fields.

      Upon investigation it seems that someone added the border attribute back to HtmlGraphicImageTagBase after MYFACES-363 was closed, presumably because it was breaking the SwapImage example page that makes use of the border attribute.

      It seems to me that the better solution is to have HtmlSwapImageTag extend org.apache.myfaces.taglib.html.ext.HtmlGraphicImageTag, so as to retain the ability to include the HTML 4.0 <img> attributes while not breaking compliance of <h:graphicImage> with the JSF 1.1 spec.

      Attachments

        1. HtmlGraphicImageTagBase.patch
          1 kB
          Jeremy Grelle
        2. HtmlSwapImageTag.patch
          0.8 kB
          Jeremy Grelle

        Activity

          People

            mmarinschek Martin Marinschek
            jgrelle Jeremy Grelle
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: