Issue Details (XML | Word | Printable)

Key: MODPYTHON-194
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Graham Dumpleton
Reporter: Graham Dumpleton
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
mod_python

Memory leak due to not clearing thread state object before deletion.

Created: 21/Oct/06 12:18 AM   Updated: 01/May/07 10:49 AM
Component/s: core
Affects Version/s: 3.2.10
Fix Version/s: 3.3.1

Time Tracking:
Not Specified

Resolution Date: 21/Oct/06 05:25 AM


 Description  « Hide
Jeff Robbins reported a potential memory leak in mod_python as a result of PyThreadState_Clear() not being called prior to PyThreadState_Delete. See:

  http://mail-archives.apache.org/mod_mbox/httpd-python-dev/200610.mbox/%3c3308644A-9EE5-48BA-845F-EF3F43BB68FF@dscpl.com.au%3e

Problem looks to be valid, but as per followup:

  http://mail-archives.apache.org/mod_mbox/httpd-python-dev/200610.mbox/%3cA62494E5-D8FE-458B-9700-EEEC1EB11FE8@dscpl.com.au%3e

the location of the PyThreadState_Clear() call would need to be moved to before the lock is released.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Graham Dumpleton made changes - 21/Oct/06 04:59 AM
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Graham Dumpleton made changes - 21/Oct/06 05:25 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Repository Revision Date User Message
ASF #466338 Sat Oct 21 05:25:50 UTC 2006 grahamd (MODPYTHON-194) Fixed potential memory leak when thread state objects weren't
cleared before they were being deleted.
Files Changed
MODIFY /httpd/mod_python/trunk/src/mod_python.c
MODIFY /httpd/mod_python/trunk/lib/python/mod_python/__init__.py
MODIFY /httpd/mod_python/trunk/Doc/appendixc.tex
MODIFY /httpd/mod_python/trunk/src/include/mpversion.h

Graham Dumpleton made changes - 01/May/07 10:49 AM
Status Resolved [ 5 ] Closed [ 6 ]