[MNG-6159] Child path adjustments break git scm urls

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6.1
• Flags: Patch
• Assignee: Herve Boutemy
• Reporter: Christian Aistleitner
• Created: 21/Jan/17 02:43
• Updated: 24/Feb/19 09:40
• Resolved: 24/Feb/19 09:40

Description

While child path adjustments make sense for some scms, child path
adjustment break git scm urls.

Consider a parent project Foo which is available at http://github.com:ExampleOrg/Foo and uses

[...]
<developerConnection>scm:git:[e-mail]:ExampleOrg/${project.artifactId}.git</developerConnection>
[...]

If a project Bar in the repo at http://github.com:ExampleOrg/Bar uses Foo as parent and inherits <developerConnection>, it ends up with the value

scm:git:[e-mail]:ExampleOrg/${project.artifactId}.git/Foo

which is not usable due to the child path adjustment.

While this bit us, we're not alone. Looking at the reported URLs, child path adjustments for git scm urls are also caused issues in these places:

https://github.com/vorburger/MariaDB4j/issues/43
https://gist.github.com/escowles/f46d158cdaf955e34282
http://transcripts.jboss.org/channel/irc.freenode.org/%23aerogear/2014/%23aerogear.2014-07-03.log.html (search for "not a valid repository name")

Issue Links

• is superceded by: MNG-5951 add an option to avoid path addition to inherited URLs
• is superceded by: MNG-6059 Important use cases not covered, as child.inherit.append.path affects all children