[METRON-624] Comparison Operators Evaluate Incorrectly

• Type: Bug
• Status: Done
• Priority: Major
• Resolution: Done
• Fix Version/s: 0.3.1
• Labels: stellar
• Assignee: Unassigned
• Reporter: Josh Meyer
• Created: 12/Dec/16 20:02
• Updated: 26/Jan/17 22:47
• Resolved: 26/Jan/17 22:47

Description

Currently there is an issue with the way Stellar interprets comparison expressions. Currently it only compares numbers when both sides are numbers otherwise it converts both sides of the expression to a value and then compares them. Also, when looking at numbers it always gets double values to compare.

Below is an example of a failing test that should pass.

  @Test
  public void compareNumberAndStringWithSameValueShouldFail() throws Exception {
    final Map<String, String> variableMap = new HashMap<>();
    assertFalse(runPredicate("1 == '1'", variableMap::get));
  }

Issue Links

• links to: GitHub Pull Request #404