[MESOS-9005] find_package_helper makes using packages REQUIRED

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: cmake
• Labels: tech-debt
• Epic Link: cmake-improvements
• Assignee: Unassigned
• Reporter: Benjamin Bannier
• Created: 18/Jun/18 09:03
• Updated: 01/Jul/20 13:53

Description

We currently implement a cmake function find_package_helper which, in addition to finding package artifacts, also by hand implements much of the functionality of find_package_handle_standard_args.

One aspect not replicated is the handling of the REQUIRED flag to find_package. Instead find_package_helper always generates a hard error if an artifact cannot be found.

It might be simpler to separate the discovery logic from the error handling logic, and delegate as much as possible to find_package_handle_standard_args so that we not only simplify our custom code, but also get the expected find_package semantics.