[MESOS-8852] process::loop does not guarantee stack overflow prevention.

• Type: Bug
• Status: Accepted
• Priority: Major
• Resolution: Unresolved
• Component/s: libprocess
• Assignee: Unassigned
• Reporter: Benjamin Mahler
• Created: 27/Apr/18 21:53
• Updated: 06/Feb/19 17:12

Description

One of the goals of process::loop is to prevent stack overflows in the case that the callbacks are completing synchronously. However, it's still possible for process::loop to stack overflow if the body and iterate futures transition between the checking of them being ready and the setting of the continuation callbacks. If the futures continuously transition in these windows, the stack will overflow.

One way to fix this would be to provide an atomic set-callbacks-if-pending function on Future (e.g. bool setIfPending(...) that allows the caller to avoid accidentally invoking callbacks synchronously when setting the callbacks.

Issue Links

• is related to: MESOS-8594 Mesos master stack overflow in libprocess socket send loop.
• is related to: MESOS-9024 Mesos master segfaults with stack overflow under load.