[MESOS-8446] Agent miss to detach `virtualLatestPath` for the executor's sandbox during recovery

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.5.0, 1.6.0
• Component/s: agent
• Target Version/s: 1.6.0
• Sprint: Mesosphere Sprint 72
• Story Points: 1
• Assignee: Qian Zhang
• Reporter: Qian Zhang
• Shepherd: Vinod Kone
• Created: 15/Jan/18 13:45
• Updated: 17/Jan/18 03:00
• Resolved: 17/Jan/18 03:00

Description

In Framework::recoverExecutor(), we attach executor->directory to 3 virtual paths:
(1) /agent_workdir/frameworks/FID/executors/EID/runs/CID
(2) /agent_workdir/frameworks/FID/executors/EID/runs/latest
(3) /frameworks/FID/executors/EID/runs/latest
But in this method, when we find the executor completes, we only do detach for (1) and (2) but not (3). We should do detach for (3) too as what we do in Slave::removeExecutor, otherwise, it will be a leak.