[MESOS-8368] Improve HTTP parser to support HTTP/2 messages.

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Labels: mesosphere
• Assignee: Unassigned
• Reporter: Armand Grillet
• Created: 02/Jan/18 17:02
• Updated: 09/Nov/18 10:56

Description

We currently use http-parser to parse HTTP messages. This parser does not work with HTTP/2 requests and responses which as an issue as curl enables HTTP/2 by default for HTTPS connections since its version 7.47.

The issue has been discovered in some of our tests (e.g. ProvisionerDockerTest) where it crashes with the message Failed to decode HTTP responses: Decoding failed. See MESOS-8335 for more details.

Possible long-term solutions:

• Upgrade the parser to be compatible with HTTP/2 messages. http-parser has not been updated regularly this past year in favor of nghttp2 which has a much broader scope. There is no equivalent of http-parser for HTTP/2 yet.
• Test which version of curl is used at startup and report an error if the version is >= 7.47 and the flag --http1.0 is not used in curl (more details regarding this flag are available here.

In the meantime, we are upgrading our testing machines using a recent version of curl to run with the flag --http1.0 (MESOS-8335).

Issue Links

• is related to: MESOS-8335 ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2 fails on Debian 9 and CentOS 6.
• relates to: MESOS-8907 Docker image fetcher fails with HTTP/2.