[MESOS-6575] Change `disk/xfs` isolator to terminate executor when it exceeds quota

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: agent, containerization
• Epic Link: XFS
• Assignee: James Peach
• Reporter: Santhosh Kumar Shanmugham
• Created: 10/Nov/16 22:04
• Updated: 07/May/18 15:59
• Resolved: 30/Apr/18 21:23

Description

Unlike disk/du isolator which sends a ContainerLimitation protobuf when the executor exceeds the quota, disk/xfs isolator, which relies on XFS's internal quota enforcement, silently fails the write operation, that causes the quota limit to be exceeded, without surfacing the quota breach information.

This task is to change the `disk/xfs` isolator so that, a ContainerLimitation message is triggered when the quota is exceeded.

This feature will rely on the underlying filesystem being mounted with pqnoenforce (accounting-only mode), so that XFS does not silently causes a EDQUOT error on writes that causes the quota to be exceeded. Now the isolator can track the disk quota via xfs_quota, very much like disk/du using du, every container_disk_watch_interval and surface the disk quota limit exceed event via a ContainerLimitation protobuf, causing the executor to be terminated. This feature can then be turned on/off via the existing enforce_container_disk_quota option.

Issue Links

• is related to: MESOS-5116 Add support for accounting only mode in XFS isolator.
• is related to: MESOS-5158 Provide XFS quota support for persistent volumes.