[#MATH-276] Calculate isNan and isFinite in Complex constructor

Commons Math

Calculate isNan and isFinite in Complex constructor

Created: 17/Jun/09 09:00 AM Updated: 07/Aug/09 09:16 AM

Return to search

Component/s:

None

Affects Version/s:

2.0

Fix Version/s:

2.0

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	Complex.patch	2009-06-17 09:01 AM	Mark Anderson	1 kB

Resolution Date:

05/Jul/09 01:00 PM

Description

« Hide

From profiling some code performing a large number of FFT operations I found that due to isNaN being called as part of complex arithmetic a large proportion of time was spent within isNaN.

I would propose calculating isNaN and isFinite in the constructor to save calculating these values each time the methods are called.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Mark Anderson made changes - 17/Jun/09 09:01 AM

Field	Original Value	New Value
Attachment		Complex.patch [ 12410911 ]

[ Permlink | « Hide ]

Phil Steitz added a comment - 17/Jun/09 11:01 AM

Patch applied in r785552. Thanks!

Phil Steitz made changes - 17/Jun/09 11:01 AM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Phil Steitz added a comment - 18/Jun/09 02:25 AM

Per Luc's comment on dev list, we need to address serialization overhead issue. Custom serialization and new fields transient?

Phil Steitz made changes - 18/Jun/09 02:25 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

[ Permlink | « Hide ]

Luc Maisonobe added a comment - 05/Jul/09 01:00 PM

closing the issue as it was solved some weeks ago (2009-06-23), as of r787521 by Phil and Bill

Luc Maisonobe made changes - 05/Jul/09 01:00 PM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Luc Maisonobe added a comment - 07/Aug/09 09:16 AM

closing resolved issue for 2.0 release

Luc Maisonobe made changes - 07/Aug/09 09:16 AM

Status

Resolved [ 5 ]

Closed [ 6 ]