[MAHOUT-166] Potpourri 2

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.2
• Assignee: Sean R. Owen
• Reporter: Sean R. Owen
• Due: 28/Aug/09
• Created: 22/Aug/09 18:36
• Updated: 17/Sep/12 20:04
• Resolved: 24/Aug/09 20:16

Description

Another large changelist constructed from FindBugs and IntelliJ analysis. It's big enough I figured I'd run it by the list. Key changes:

• Making stuff final, private that can be
• Dead code elimination
• Simplifying JUnit assertions – "assertTrue(a.equals(b) == true)" could be "assertEquals(a, b)" for instance. Also fixed some expected/actual value issues
• Not compiling a Pattern object millions of times – String.split() and replace()/replaceAll() do this and can be profitably replaced with a precompiled Pattern.
• Small bug fixes picked up by analysis