[LUCENE-9971] Inconsistent SSDVFF and Taxonomy facet behavior in case of unseen dimension

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Alexander Lukyanchikov
• Created: 25/May/21 03:07
• Updated: 28/Aug/22 16:22
• Resolved: 31/May/21 13:26

Description

Unlike other org.apache.lucene.facet.Facet interface implementations, SortedSetDocValuesFacetCounts and ConcurrentSortedSetDocValuesFacetCounts throw an exception in case of unseen dimension in the getTopChildren() method  

It is inconsistent with Facet interface documentation and not pleasant to deal with: in our case requested dimensions can be manually specified by the user, so we should always catch that and check the exception message to be sure of the exact cause.

During the PR review, it was also decided to make similar changes for Taxonomy implementation.

Issue Links

• links to: GitHub Pull Request #149
• links to: GitHub Pull Request #161