[LUCENE-9940] The order of disjuncts in DisjunctionMaxQuery affects equals() impl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Lucene Fields: New
• Assignee: Alan Woodward
• Reporter: Alan Woodward
• Created: 27/Apr/21 14:00
• Updated: 28/Aug/22 16:21
• Resolved: 29/Apr/21 08:48

Description

DisjunctionMaxQuery stores its disjuncts in a java array, and its equals() implementation uses Arrays.equal() when checking equality. This means that two queries with the same disjuncts but added in a different order will compare as different, even though their results will be identical. We should replace the array with a Set.

Issue Links

• relates to: SOLR-15389 Certain tests rely on DisjunctionMaxQuery clause order
• links to: GitHub Pull Request #110