Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-9902

Update faceting API to use modern Java features

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • None
    • modules/facet
    • None

    Description

      I was using the public int getOrdinal(String dim, String[] path) API for a singleĀ path String and found myself creating an array with a single element. We can start using variable length args for this method.

      I also propose this change:
      I wanted to know the specific count of an ordinal using using the getValue API from IntTaxonomyFacets but the method is private. It would be good if we could change it to protected so that users can know the value of an ordinal without looking up the FacetLabel and then checking its value.

      Attachments

        Activity

          People

            Unassigned Unassigned
            gworah Gautam Worah
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h 20m
                2h 20m