[LUCENE-9618] Improve IntervalIterator.nextInterval's behavior/documentation/test

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: modules/query
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Patrick Zhai
• Created: 19/Nov/20 18:32
• Updated: 28/Aug/22 16:10
• Resolved: 03/Dec/20 16:06

Description

I'm trying to play around with my own IntervalSource and found out that nextInterval method of IntervalIterator will be called sometimes even after nextDoc/ docID/ advance method returns NO_MORE_DOCS.
 
After I dug a bit more I found that FilteringIntervalIterator.reset is calling an inner iterator's nextInterval regardless of what the result of nextDoc, and also most (if not all) existing IntervalIterator's implementation do considered the case where nextInterval is called after nextDoc returns NO_MORE_DOCS.
 
We should probably update the javadoc and test if the behavior is necessary. Or we should change the current implementation to avoid this behavior
original email discussion thread:

https://markmail.org/thread/aytal77bgzl2zafm

Issue Links

• links to: GitHub Pull Request #2090
• links to: GitHub Pull Request #2095