Details
Description
We introduced a broken behavior that leaks memory in DWPTDeleteQueue recently (LUCENE-9304) The line here tries to be smart and even adds a comment that the current impl is safe but it isn't if you reference a final member in a lambda it references this which holds on to the object. I think we need to do a quick 8.6.2 for this.
Attachments
Issue Links
- links to
Commit 098f0dc8b414ca9c9a47cf7ebf4383198fb946fe in lucene-solr's branch refs/heads/master from Simon Willnauer
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=098f0dc ]
LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779)In
LUCENE-9304we introduced some fixes that unfortunately hold on to the previousDWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail.
This fixes the memory leak and adds a test to ensure its not leaking memory.