Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 9.0, 8.7, 8.6.1
    • 9.0, 8.7, 8.6.2
    • None
    • None
    • New, Patch Available

    Description

      We introduced a broken behavior that leaks memory in DWPTDeleteQueue recently (LUCENE-9304) The line here tries to be smart and even adds a comment that the current impl is safe but it isn't if you reference a final member in a lambda it references this which holds on to the object. I think we need to do a quick 8.6.2 for this.

      Attachments

        Issue Links

          Activity

            Commit 098f0dc8b414ca9c9a47cf7ebf4383198fb946fe in lucene-solr's branch refs/heads/master from Simon Willnauer
            [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=098f0dc ]

            LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779)

            In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous
            DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail.
            This fixes the memory leak and adds a test to ensure its not leaking memory.

            jira-bot ASF subversion and git services added a comment - Commit 098f0dc8b414ca9c9a47cf7ebf4383198fb946fe in lucene-solr's branch refs/heads/master from Simon Willnauer [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=098f0dc ] LUCENE-9478 : Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779) In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail. This fixes the memory leak and adds a test to ensure its not leaking memory.

            Commit feb38aac69b2b48605350ed7cf90230d84dd129e in lucene-solr's branch refs/heads/branch_8_6 from Simon Willnauer
            [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=feb38aa ]

            LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779)

            In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous
            DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail.
            This fixes the memory leak and adds a test to ensure its not leaking memory.

            jira-bot ASF subversion and git services added a comment - Commit feb38aac69b2b48605350ed7cf90230d84dd129e in lucene-solr's branch refs/heads/branch_8_6 from Simon Willnauer [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=feb38aa ] LUCENE-9478 : Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779) In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail. This fixes the memory leak and adds a test to ensure its not leaking memory.

            Commit 81e405f1c5242bcc3c0fb6a0c8a55b5cfa5889af in lucene-solr's branch refs/heads/branch_8x from Simon Willnauer
            [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=81e405f ]

            LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779)

            In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous
            DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail.
            This fixes the memory leak and adds a test to ensure its not leaking memory.

            jira-bot ASF subversion and git services added a comment - Commit 81e405f1c5242bcc3c0fb6a0c8a55b5cfa5889af in lucene-solr's branch refs/heads/branch_8x from Simon Willnauer [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=81e405f ] LUCENE-9478 : Prevent DWPTDeleteQueue from referencing itself and leaking memory (#1779) In LUCENE-9304 we introduced some fixes that unfortunately hold on to the previous DWPTDeleteQueue which is essentially leaking IW memory and cause applications to fail. This fixes the memory leak and adds a test to ensure its not leaking memory.
            ivera Ignacio Vera added a comment -

            Closing after the 8.6.2 release

            ivera Ignacio Vera added a comment - Closing after the 8.6.2 release
            tomoko Tomoko Uchida added a comment -

            This issue was moved to GitHub issue: #10517.

            tomoko Tomoko Uchida added a comment - This issue was moved to GitHub issue: #10517 .

            People

              simonw Simon Willnauer
              simonw Simon Willnauer
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2.5h
                  2.5h