[LUCENE-9411] Fail complation on warnings, 9x gradle-only

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 9.0
• Component/s: general/build
• Labels: build
• Lucene Fields: New
• Assignee: Erick Erickson
• Reporter: Erick Erickson
• Created: 18/Jun/20 19:48
• Updated: 28/Aug/22 16:04
• Resolved: 08/Jul/20 20:15

Description

Moving this over here from SOLR-11973 since it's part of the build system and affects Lucene as well as Solr. You might want to see the discussion there.

We have a clean compile for both Solr and Lucene, no rawtypes, unchecked, try, etc. warnings. There are some peculiar warnings (things like SuppressFBWarnings, i.e. FindBugs) that I'm not sure about at all, but let's assume those are not a problem. Now I'd like to start failing the compilation if people write new code that generates warnings.

From what I can tell, just adding the flag is easy in both the Gradle and Ant builds. I still have to prove out that adding -Werrors does what I expect, i.e. succeeds now and fails when I introduce warnings.

But let's assume that works. Are there objections to this idea generally? I hope to have some data by next Monday.

FWIW, the Lucene code base had far fewer issues than Solr, but common-build.xml is in Lucene.

Issue Links

• contains: SOLR-11973 Fail compilation on warnings
• fixes: SOLR-11973 Fail compilation on warnings
• is related to: SOLR-15988 Remove gradle/hacks/solr.findbugs.gradle