[LUCENE-9362] ExpressionValueSource has buggy rewrite method

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 8.6
• Component/s: modules/expressions
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Dmitry Emets
• Created: 05/May/20 16:05
• Updated: 28/Aug/22 16:02
• Resolved: 07/May/20 15:32

Description

ExpressionValuesSource does not actually rewrite itself due to small mistake in check of inner rewrites.

changed |= (rewritten[i] == variables[i]);

should be changed to

changed |= (rewritten[i] != variables[i]);

Issue Links

• links to: GitHub Pull Request #1485