[LUCENE-8906] Lucene50PostingsReader.postings() casts BlockTermState param to private IntBlockTermState

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 8.3
• Component/s: core/codecs
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: Bruno Roustant
• Created: 09/Jul/19 08:03
• Updated: 22/Sep/22 17:41
• Resolved: 01/Aug/19 22:35

Description

Lucene50PostingsReader is the public API that offers the postings() method to read the postings. Any PostingFormat can use it (as well as Lucene50PostingsWriter) to read/write postings.

But the postings() method asks for a (public) BlockTermState param which is internally cast to the private IntBlockTermState. This BlockTermState is provided by Lucene50PostingsReader.newTermState().

public PostingsEnum postings(FieldInfo fieldInfo, BlockTermState termState, PostingsEnum reuse, int flags)

This actually makes impossible to a custom PostingFormat customizing the Block file structure to use this postings() method by providing their (Int)BlockTermState, because they cannot access the FP fields of the IntBlockTermState returned by PostingsReaderBase.newTermState().

Proposed change:

• Either make IntBlockTermState public, as well as its fields.
• Or replace it by an interface in the postings() method. In this case the IntBlockTermState fields currently accessed directly would be replaced by getter/setter.

Issue Links

• links to: GitHub Pull Request #798