Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-8866

Remove ICU dependency of kuromoji tools/test-tools

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 8.2
    • None
    • None
    • New

    Description

      The tooling stuff has an off-by-default option to normalize entries, currently using the ICU api.

      But I think since its off-by-default, and just doing NFKC normalization at dictionary-build-time, its a better tradeoff to use the JDK here?

      I would rather remove the ICU dependency for the tooling and look at simplifying the build to have less modules (e.g. investigate moving the tooling and tests into src/java and src/tools, so that msokolov@gmail.com new tests in LUCENE-8863 are running by default, dictionary tool is shipped as a commandline tool in the JAR, etc)

      "ant regenerate" should be enough to prevent any chicken-and-eggs in the dictionary construction code, so I don't think we need separate modules to enforce it.

      Attachments

        1. LUCENE-8866.patch
          4 kB
          Robert Muir

        Activity

          People

            Unassigned Unassigned
            rcmuir Robert Muir
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: