[LUCENE-8818] smokeTestRelease.py encoding bug

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 9.0, 8.2, 8.1.2
• Component/s: general/tools
• Lucene Fields: New
• Assignee: Jan Høydahl
• Reporter: Jan Høydahl
• Created: 01/Jun/19 19:17
• Updated: 28/Aug/22 15:45
• Resolved: 06/Jun/19 19:46

Description

Smoke tester may crash while parsing log file created from gpg stdout, but only in certain conditions. Error trace is

Test Lucene...
 test basics...
 check changes HTML...
 download lucene-7.7.2-src.tgz...
   43.5 MB in 123.23 sec (0.4 MB/sec)
   verify sha512 digest
   verify sig
Traceback (most recent call last):
 File "dev-tools/scripts/smokeTestRelease.py", line 1518, in <module>
   main()
 File "dev-tools/scripts/smokeTestRelease.py", line 1448, in main
   smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, c.local_keys, ' '.join(c.test_args))
 File "dev-tools/scripts/smokeTestRelease.py", line 1497, in smokeTest
   checkSigs('lucene', lucenePath, version, tmpDir, isSigned, keysFile)
 File "dev-tools/scripts/smokeTestRelease.py", line 379, in checkSigs
   for line in f.readlines():
 File "/Users/ab/anaconda3/lib/python3.7/codecs.py", line 322, in decode
   (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf8 in position 180: invalid start byte

The failing line is https://github.com/apache/lucene-solr/blob/faaee86efb01fa6e431fcb129cfb956c7d62d514/dev-tools/scripts/smokeTestRelease.py#L378

Found by ab