[LUCENE-8261] InterpolatedProperties.interpolate and recursive property references

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 7.4
• Lucene Fields: New
• Assignee: Dawid Weiss
• Reporter: Dawid Weiss
• Created: 20/Apr/18 10:13
• Updated: 28/Aug/22 15:28
• Resolved: 07/May/18 11:24

Description

InterpolatedProperties is used in lib check tasks in the build file. I occasionally see this:

/home/jenkins/workspace/Lucene-Solr-master-Linux/lucene/tools/custom-tasks.xml:108: java.lang.IllegalArgumentException: named capturing group is missing trailing '}'
        at java.base/java.util.regex.Matcher.appendExpandedReplacement(Matcher.java:1052)
        at java.base/java.util.regex.Matcher.appendReplacement(Matcher.java:908)
        at org.apache.lucene.dependencies.InterpolatedProperties.interpolate(InterpolatedProperties.java:64)

I don't think we ever need to use any group references in those replacements; they should be fixed strings (quoted verbatim)? So Pattern.quoteReplacement would be adequate here.