[LUCENE-7859] PackedQuadCell.getTokenBytesNoLeaf bug when null BytesRef

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0
• Component/s: modules/spatial-extras
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 01/Jun/17 05:07
• Updated: 28/Aug/22 15:16
• Resolved: 01/Jun/17 05:14

Description

PackedQuadCell.getTokenBytesNoLeaf and PackedQuadCell.getTokenBytesWithLeaf have a couple issues that were exposed in LUCENE-7845. One is that the WithLeaf version actually modifies the state (long term) which it shouldn't. Another is that if the BytesRef is null, it can compute a different result than if it's not null, which is definitely wrong.

It appears that these problems are only revealing themselves in practice with the LUCENE-7845 optimization since there has been no PackedQuad test failure before, and RandomSpatialOpFuzzyPrefixTreeTest really hammers the prefix tree.

Issue Links

• breaks: LUCENE-7845 spatial RPT optimization when query by point or common date range