[LUCENE-7564] AnalyzingInfixSuggester should close its IndexWriter by default at the end of build()

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.4, 7.0
• Assignee: Steven Rowe
• Reporter: Steven Rowe
• Created: 16/Nov/16 18:19
• Updated: 28/Aug/22 15:06
• Resolved: 30/Dec/16 00:41

Description

From SOLR-6246, where AnalyzingInfixSuggester's write lock on its index is causing trouble when reloading a Solr core:

gsingers wrote:

One suggestion that might minimize the impact: close the writer after build

varunthacker wrote:

This is what I am thinking -

Create a Lucene issue in which AnalyzingInfixSuggester#build closes the writer by default at the end.
The add and update methods call ensureOpen and those who do frequent real time updates directly via lucene won't see any slowdowns.

mikemccand - Would this approach have any major drawback from Lucene's perspective? Else I can go ahead an tackle this in a Lucene issue

mikemccand wrote:

Fixing AnalyzingInfixSuggester to close the writer at the end of build seems reasonable?

Issue Links

• breaks: LUCENE-7670 AnalyzingInfixSuggester should not immediately open an IndexWriter over an already-built index
• relates to: SOLR-6246 Core fails to reload when AnalyzingInfixSuggester is used as a Suggester