[LUCENE-6900] Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.5
• Component/s: modules/grouping
• Lucene Fields: New
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 19/Nov/15 05:10
• Updated: 28/Aug/22 14:46
• Resolved: 26/Nov/15 05:16

Description

In AbstractSecondPassGroupingCollector, withinGroupSort uses a value of null to indicate a relevance sort. I think it's nicer to use Sort.RELEVANCE for this – after all it's how the groupSort variable is handled. This choice is also seen in GroupingSearch; likely some other collaborators too.

martijn.v.groningen is there some wisdom in the current choice that escapes me? If not I'll post a patch.

Issue Links

• breaks: SOLR-8940 group.sort broken, can through AIOOBE if clause length differs from sort param, or cast exception if datatypes are incompatible with sort clause types
• relates to: SOLR-9783 remove no-longer-needed sortWithinGroup null checks in (Search|Top)Group[s]ShardResponseProcessor