[LUCENE-5570] FSDirectory's fsync() is lenient

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.7.2, 4.8, 6.0
• Component/s: core/store
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 03/Apr/14 19:14
• Updated: 28/Aug/22 14:04
• Resolved: 15/Apr/14 09:42

Description

This method has a lot of problems:
1. it tracks 'stale files' as it writes (this seems pointless), and only actually fsyncs the intersection of that 'stale files' and the filenames passed as argument to sync(). So any bogus names passed to sync() are just silently ignored
2. if "something bad happens" (e.g. two indexwriters/dirs on the same path, or some other shenanigans), and the file is actually in stale files, but was say actually deleted on the filesystem, the underlying fsync() call will create a new 0-byte file and fsync that.

In my opinion we should do none of this. we should throw exceptions when this stuff is wrong.

Issue Links

• is related to: LUCENE-6150 Remove staleFiles set and onIndexOutputClosed from FSDirectory
• is required by: LUCENE-5588 We should also fsync the directory when committing