[LUCENE-4663] IndexSearcher.document() should not be final

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.1, 6.0
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 06/Jan/13 13:30
• Updated: 28/Aug/22 13:35
• Resolved: 07/Jan/13 18:13

Description

IndexSearcher has 3 methods:

StoredDocument doc(int)
void doc(int, StoredFieldVisitor)
final StoredDocument document(int, Set<String>)

The last one is confusing for subclasses (e.g. SolrIndexSearcher) that override these methods. for example that one has its own StoredDocument doc(int, Set) method.

But now this means a user could always call the wrong method (this final document() method) and get the wrong behavior (versus calling doc()).

I think the name is also wrong. it should be doc() like the others.