[LUCENE-4443] BlockPostingsFormat writes unnecessary skipdata

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.1, 6.0
• Component/s: core/codecs
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 28/Sep/12 01:28
• Updated: 28/Aug/22 13:28
• Resolved: 28/Sep/12 14:15

Description

Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly is 0: see BlockPostingsWriter.startDoc.

(Unless I'm missing something, all tests pass with "Block" if i remove it)

Separately we should really think about lastPayloadByteUpto, is this worth it? instead when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we are going to decode that block anyway?