[LUCENE-4165] HunspellDictionary - AffixFile Reader closed, Dictionary Readers left unclosed

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.6
• Fix Version/s: 3.6.1, 4.0-BETA, 6.0
• Component/s: modules/analysis

Environment

Linux, Java 1.6

• Lucene Fields: New
• Assignee: Chris Male
• Reporter: Torsten Krah
• Created: 26/Jun/12 07:59
• Updated: 28/Aug/22 13:20
• Resolved: 17/Jul/12 06:06

Description

The HunspellDictionary takes an InputStream for affix file and a List of Streams for dictionaries.

Javadoc is not clear about i have to close those stream myself or the Dictionary constructor does this already.

Looking at the code, at least reader.close() is called when the affix file is read via readAffixFile() method (although closing streams is not done in a finally block - so the constructor may fail to do so).
The readDictionaryFile() method does miss the call to close the reader in contrast to readAffixFile().

So the question here is - have i have to close the streams myself after instantiating the dictionary?
Or is the close call only missing for the dictionary streams?
Either way, please add the close calls in a safe manner or clarify javadoc so i have to do this myself.