[LUCENE-4163] Improve concurrency in MMapIndexInput.clone()

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.6, 4.0-ALPHA, 6.0
• Fix Version/s: 4.0-ALPHA, 3.6.1, 6.0
• Component/s: core/store
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 22/Jun/12 08:30
• Updated: 28/Aug/22 13:20
• Resolved: 16/Jul/12 20:36

Description

Followup issue from SOLR-3566:

Whenever you clone the TermIndex, it also creates a clone of the underlying IndexInputs. In high cocurrent environments, the clone method of MMapIndexInput is a bottleneck (it has heavy work to do to manage the weak references in a synchronized block).

Everywhere else in Lucene we use my new WeakIdentityMap for managing concurrent weak maps. For this case I did not do this, as the WeakIdentityMap has no iterators (it doe snot implement Map interface). This issue will add a key and values iterator (the key iterator will not return GC'ed keys), so MMapIndexInput can use WeakIdentityMap backed by ConcurrentHashMap and needs no synchronization. ConcurrentHashMap has better concurrency because it distributes the hash keys in different buckets per thread.

Issue Links

• relates to: SOLR-3566 solr CPU 100%