[LUCENE-3557] Spellchecker should take IndexWriterConfig... deprecate old methods?

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.5, 4.0-ALPHA
• Lucene Fields: New
• Assignee: Robert Muir
• Reporter: Robert Muir
• Created: 03/Nov/11 12:38
• Updated: 28/Aug/22 13:01
• Resolved: 04/Nov/11 10:10

Description

When looking at LUCENE-3490, i realized there was no way to specify the codec for the spellchecker to use.

It has the following current methods:

• indexDictionary(Dictionary dict): this causes optimize!
• indexDictionary(Dictionary dict, int mergeFactory, int ramMB): this causes optimize!
• indexDictionary(Dictionary dict, int mergeFactor, int ramMB, boolean optimize)

But no way to specify an IndexwriterConfig. Additionally, I don't like that several of these ctors force an optimize in a tricky way,
even though it was like this all along.

So I think we should add indexDictionary(Dictionary dict, IndexWriterConfig config, boolean optimize).

We should either deprecate all the other ctors in 3.x and nuke in trunk, or at least add warnings to the ones that optimize.

Issue Links

• relates to: LUCENE-4487 SpellChecker : SpellChecker.indexDictionary : Javadoc incorrect