[LUCENE-3556] Make DirectoryTaxonomyWriter's indexWriter member private

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 3.5, 4.0-ALPHA
• Component/s: modules/facet
• Lucene Fields: New, Patch Available
• Assignee: Shai Erera
• Reporter: Shai Erera
• Created: 03/Nov/11 06:49
• Updated: 28/Aug/22 13:01
• Resolved: 03/Nov/11 07:42

Description

DirectoryTaxonomyWriter has a protected indexWriter member. As far as I can tell, for two reasons:

1. protected openIndexWriter method which lets you open your own IW (e.g. with a custom IndexWriterConfig).
2. protected closeIndexWriter which is a hook for letting you close the IW you opened in the previous one.

The fixes are trivial IMO:

1. Modify the method to return IW, and have the calling code set DTW's indexWriter member
2. Eliminate closeIW. DTW already has a protected closeResources() which lets you clean other resources you've allocated, so I think that's enough.

I'll post a patch shortly.